Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message-system 72 - reintroduce recovery message for t1b1 #16089

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

MiroslavProchazka
Copy link
Contributor

@MiroslavProchazka MiroslavProchazka commented Dec 20, 2024

Since we allowed Check Backup/Create Backup Connect messages even for unsupported firmware in Suite release 24.12.3, I’m reintroducing this message to enable users with older T1B1 firmware to check their backup before updating the firmware.

Tracked in Notion here

Copy link

github-actions bot commented Dec 20, 2024

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 21
  • More info

Learn more about 𝝠 Expo Github Action

@MiroslavProchazka MiroslavProchazka force-pushed the chote/reintroduce-recovery branch 2 times, most recently from 509ea34 to 88af830 Compare December 21, 2024 20:18
@MiroslavProchazka MiroslavProchazka changed the title chore(message-system): reintroduce recovery message for t1b1 Message-system 70 - reintroduce recovery message for t1b1 Dec 21, 2024
},
{
"model": "T1B1",
"firmware": "1.5.1>1.7.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @tomasklim @Lemonexe - just checking whether I can use the conditions like this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope it is not valid

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

greater than or equal to 1.5.1 and less than 1.7.0
"firmware": ">=1.5.1 <1.7.0"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved in e38213b

@MiroslavProchazka MiroslavProchazka marked this pull request as ready for review December 21, 2024 20:25
@MiroslavProchazka MiroslavProchazka force-pushed the chote/reintroduce-recovery branch 3 times, most recently from d47ef86 to 8d3d552 Compare December 30, 2024 14:47
@MiroslavProchazka MiroslavProchazka changed the title Message-system 70 - reintroduce recovery message for t1b1 Message-system 71 - reintroduce recovery message for t1b1 Dec 30, 2024
@MiroslavProchazka MiroslavProchazka changed the title Message-system 71 - reintroduce recovery message for t1b1 Message-system 72 - reintroduce recovery message for t1b1 Dec 30, 2024
@MiroslavProchazka MiroslavProchazka force-pushed the chote/reintroduce-recovery branch from 8d3d552 to 5b756be Compare December 30, 2024 14:50
@bosomt
Copy link
Contributor

bosomt commented Jan 2, 2025

QA OK

Screen.Recording.2025-01-02.at.12.03.43.mov

Info:

  • Suite version: web 25.1.0 (7748d59)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T1B1 1.6.3 regular (revision ef86786ff750351ec454c7bae33b4966cfa862d7)
  • Transport: BridgeTransport 2.0.33

@MiroslavProchazka MiroslavProchazka force-pushed the chote/reintroduce-recovery branch 2 times, most recently from c127145 to cce3476 Compare January 2, 2025 13:53
@MiroslavProchazka MiroslavProchazka force-pushed the chote/reintroduce-recovery branch from cce3476 to d0da7e7 Compare January 2, 2025 13:54
@tomasklim tomasklim merged commit 610f9d6 into develop Jan 2, 2025
32 of 34 checks passed
@tomasklim tomasklim deleted the chote/reintroduce-recovery branch January 2, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Approved
Development

Successfully merging this pull request may close these issues.

3 participants